Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date of flight based on localtime #2

Merged
merged 2 commits into from
Sep 15, 2012
Merged

Date of flight based on localtime #2

merged 2 commits into from
Sep 15, 2012

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 14, 2012

@ghost ghost assigned Turbo87 Sep 14, 2012
@Turbo87
Copy link
Member Author

Turbo87 commented Sep 14, 2012

from IRC:

(20:39:32) TBL: Turbo: what's about datatable sorting by date? shouldn't this use the new column, too?
(20:40:30) TBL: and the same applies for sorting by takeoff time
(20:40:41) TBL: which would need a local datetime
(20:41:38) TBL: or is it your intend to sort the takeoff times by utc time?
(20:41:47) TBL: and the dates by local date?

@Turbo87
flight: Added date_local column
b5ae752 
This column will hold the takeoff date of the flight in localtime.

This is part of the fix for ticket #2330
@Turbo87
timezone: Calculate date_local with the timezone of the takeoff_location
a2d2169
@Turbo87
Copy link
Member Author

Turbo87 commented Sep 14, 2012

@TobiasLohner sorting by date is implemented properly now. thanks for pointing that out!

I think sorting by takeoff time can still be done with UTC time.

@Turbo87
Copy link
Member Author

Turbo87 commented Sep 14, 2012

@kedder I've implemented the fallback to the UTC date for now

@kedder
Copy link
Member

kedder commented Sep 14, 2012

On 09/14/2012 01:45 PM, Tobias Bieniek wrote:

@kedder https://github.com/kedder I've implemented the fallback to the
UTC date for now

Overall it looks good to me, I have nothing to add.

Andrey Lebedev aka -.- . -.. -.. . .-.
Software engineer
Homepage: http://lebedev.lt/
Jabber ID: kedder@jabber.ru

Turbo87 added a commit that referenced this pull request Sep 15, 2012
@Turbo87
Merge pull request #2 from Turbo87/localtime
a2e991d
@Turbo87 Turbo87 merged commit a2e991d into master Sep 15, 2012
fb pushed a commit to fb/skylines that referenced this pull request Apr 26, 2014
@kedder
Flights from N different airfields achievement implemented
494ef88 
Fixes skylines-project#2.
fb pushed a commit to fb/skylines that referenced this pull request Jun 3, 2014
@kedder @fb
Flights from N different airfields achievement implemented
d8a1e58 
Fixes skylines-project#2.
@vicb vicb mentioned this pull request Dec 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Turbo87 Turbo87

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Turbo87 @kedder