Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash for low end devices. #8

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix Crash for low end devices. #8

merged 2 commits into from
Dec 2, 2021

Conversation

yogeshpaliyal
Copy link
Contributor

Guidelines

Used Coil instead of Glide to load the Image. Glide is causing java.lang.RuntimeException: Canvas: trying to draw too large.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Used Coil instead of Glide to load Image.
@skydoves
Copy link
Owner

skydoves commented Dec 2, 2021

Thank you for your contribution. :)
Just for curious, if we use the CoilImage of Landscapist, does it also resolve this issue? And it would be great if you could run the below commands for the formatting. :)

./gradlew spotlessApply

@yogeshpaliyal
Copy link
Contributor Author

@skydoves I am not sure about CoilImage from Landscapist but I used it from here
https://coil-kt.github.io/coil/compose/

@yogeshpaliyal
Copy link
Contributor Author

@skydoves formatting issue fixed

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@skydoves skydoves merged commit 6f671eb into skydoves:main Dec 2, 2021
@yogeshpaliyal yogeshpaliyal deleted the demo_crash branch December 2, 2021 17:18
@skydoves skydoves mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants