add config.schema.json to get a UI configuration dialog #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 30, 2019 12:21
…ridge-config-ui-x plugin
…at you need to calibrate your station (or open the window more freqently ;-) )
|
Hello @lisanet , thank you for your contribution. I will try to check this out next weekend and merge the PR. |
…er manual, that a calibration will use this lower level. It seems that Eve uses a different value in its sensors, see prior commit.
|
Hello @lisanet , I'm currently testing your PR and everything works fine except one startup-error here: https://github.com/lisanet/homebridge-eveatmo/blob/master/device/weatherstation-device.js#L60 If I change the NULL to null, everything works. Maybe a different node-version (I'm using 8.4). If you want I can change this and merge your PR. |
|
... one more thing: It would also be great if you can change the PR target branch to the develop-branch. |
|
ok, I've changed the PR to target your develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a configuration dialog for the homebridge-config-ui-x plugin, so that users can easily configure the eveatmo plugin via the config web UI.