MNT Add non-strict mypy to CI and fix errors #62
Conversation
This accompanies PR #61 to contrast the difference between strict and non-strict mypy usage.
| @@ -112,7 +114,7 @@ def init(*, model: Union[str, Path], requirements: List[str], dst: Union[str, Pa | |||
| None | |||
| """ | |||
| dst = Path(dst) | |||
| if dst.exists() and next(dst.iterdir(), None): | |||
| if dst.exists() and bool(next(dst.iterdir(), None)): | |||
There was a problem hiding this comment.
aha? why do we need explicit bool here? This is proper python:
>>> if 3 or None:
... print(1)There was a problem hiding this comment.
The error is:
skops/hub_utils/_hf_hub.py:117: error: Argument 1 to "next" has incompatible type "Generator[Path, None, None]"; expected "SupportsNext[bool]"
skops/hub_utils/_hf_hub.py:117: error: Argument 2 to "next" has incompatible type "None"; expected "bool"
| @@ -112,7 +114,7 @@ def init(*, model: Union[str, Path], requirements: List[str], dst: Union[str, Pa | |||
| None | |||
| """ | |||
| dst = Path(dst) | |||
| if dst.exists() and next(dst.iterdir(), None): | |||
| if dst.exists() and bool(next(dst.iterdir(), None)): | |||
E.g. def(foo: str = None)
They're not necessary to pass mypy but still useful to have.
skops/_min_dependencies.py
Outdated
| @@ -16,7 +16,8 @@ | |||
| "pytest": (PYTEST_MIN_VERSION, "tests", None), | |||
| "pytest-cov": ("2.9.0", "tests", None), | |||
| "flake8": ("3.8.2", "tests", None), | |||
| "mypy": ("0.770", "tests", None), | |||
| "mypy": ("0.971", "tests", None), | |||
There was a problem hiding this comment.
mypy isn't really a test dependency. It probably makes more sense to have it explicitly installed in CI the same as black and isort.
There was a problem hiding this comment.
Well, mypy was already there before, but sure, I'll remove it. I thought the idea of having it here is to have a single source of truth for all dependencies, so it made sense to me.
adrinjalali
changed the title
This accompanies PR #61 to contrast the difference between strict and
non-strict mypy usage.