-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT mark tests requiring internet #55
Conversation
Running Tests | ||
~~~~~~~~~~~~~ | ||
|
||
Certain tests require internet access to run, and they typically take slightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"slightly" :D
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Love a green CI! |
@adrinjalali I resolved a merge conflict. If you're fine with the outcome, let me know and we can merge this. |
Yes. looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, useful addition.
Marking the test which requires internet, and is much slower than others.
Fixes #43
cc @skops-dev/maintainers