Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR hub_utils.push #398

Merged
merged 5 commits into from
Oct 23, 2023
Merged

DEPR hub_utils.push #398

merged 5 commits into from
Oct 23, 2023

Conversation

adrinjalali
Copy link
Member

This deprecates hub_utils.push since create_repo now also has strict rate limits.

The linter issue should be fixed by merging #397 and then updating this PR.

@adrinjalali
Copy link
Member Author

Need to replace all instances of hub_utils.push to using huggingface_hub utils. We probably need to make those as comments instead of running them since our doc build would otherwise fail too.

This was referenced Oct 13, 2023
Merged
Open
@adrinjalali
Copy link
Member Author

Codecov fail be due to push not being tested. Ready for review @BenjaminBossan

@adrinjalali
Copy link
Member Author

Ping @BenjaminBossan , I can do a release once we merge this one.

BenjaminBossan
BenjaminBossan approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@adrinjalali adrinjalali merged commit 60d7063 into skops-dev:main Oct 23, 2023
15 of 16 checks passed
@adrinjalali adrinjalali deleted the tst/disable branch October 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @BenjaminBossan