Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT update linters and use ruff #397

Merged
merged 6 commits into from
Oct 13, 2023
Merged

MNT update linters and use ruff #397

merged 6 commits into from
Oct 13, 2023

Conversation

adrinjalali
Copy link
Member

This replaces flake8 and isort with ruff, which is much faster, updates linter versions, and fixes issues due to the version upgrades and using ruff.

@adrinjalali adrinjalali mentioned this pull request Oct 12, 2023
Merged
@BenjaminBossan
Copy link
Collaborator

So is the CI red here because we require #398 to be merged and CI on #398 is red because it requires this PR to be merged?

@adrinjalali
Copy link
Member Author

The CI here is passing the linter stage, so we can kinda consider this green I guess.

BenjaminBossan
BenjaminBossan approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Did you ruff to be better apart from speed, which I don't feel was a big issue to begin with.

@adrinjalali
Copy link
Member Author

Did you ruff to be better apart from speed, which I don't feel was a big issue to begin with.

It's speed, as well as having all the rules in one linter. We've switched in large projects to ruff and we're very happy with it.

@adrinjalali adrinjalali merged commit 41f71fd into skops-dev:main Oct 13, 2023
0 of 14 checks passed
@adrinjalali adrinjalali deleted the lint branch October 13, 2023 16:01
@adrinjalali adrinjalali restored the lint branch October 13, 2023 16:01
@adrinjalali adrinjalali deleted the lint branch October 17, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @BenjaminBossan