-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Add GitHub workflow for creating releases #38
Conversation
Add some documentation around releases and developing skops.
I'm getting this error:
(link) Any idea what this could be about? It seems to be unrelated to my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thos 400 errors are because the backend is unstable and sometimes gives 400. We just re-run the tests for them to pass, and they almost always do with max 3 retries. We can also use a retry decorator for our tests. |
... in README instruction. Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
The error on the CI doesn't seem like the usual we get. Would you what's causing it @SBrandeis?
|
python -m pip install -U setuptools wheel twine | ||
|
||
- name: Publish package to TestPyPI | ||
uses: pypa/gh-action-pypi-publish@v1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this action only publishes the built packages. We need to build them before uploading them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have checked, my bad. I added a build step above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how it goes.
|
||
- name: Generate distribution archives | ||
run: | | ||
python -m build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, didn't know this does the thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, it was new to me. But I figured if the docs recommend this way, it is best practice.
Solves #34
Minor additions:
Note: For obvious reasons, I haven't tested yet whether the GH action really works.