FIX: Persistence tests failing when using sklearn nightly #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is urgent because CI for our PRs will fail until there is a fix. After scikit-learn/scikit-learn#22094, sklearn estimators will contain an additional key in their __dict__ after loading, namely "__sklearn_pickle_version__". This causes our tests to fail, since they compare objects before and after loading. The quick solution is to pop the item in our tests if it exists and only compare the remaining items. Should the sklearn change be amended, we should remove the fix from this PR. Progress is tracked here: scikit-learn/scikit-learn#25273
BenjaminBossan
changed the title
|
@skops-dev/maintainers this is ready for review. Here is an example test run that currently fails because of this issue. |
adrinjalali
added a commit
to adrinjalali/skops
that referenced
this pull request
Jan 13, 2023
…ops-dev#260)" This reverts commit 1b3c674.
adrinjalali
added a commit
to adrinjalali/skops
that referenced
this pull request
Jan 13, 2023
…ops-dev#260)" This reverts commit 1b3c674.
BenjaminBossan
pushed a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is urgent because CI for our PRs will fail until there is a fix.
After scikit-learn/scikit-learn#22094, sklearn estimators will contain an additional key in their
__dict__after loading, namely"__sklearn_pickle_version__". This causes our tests to fail, since they compare objects before and after loading.The quick solution is to pop the item in our tests if it exists and only compare the remaining items.
Should the sklearn change be amended, we should remove the fix from this PR. Progress is tracked here:
scikit-learn/scikit-learn#25273