-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Edit style of model plot to fit in the page #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rushic24. We don't have a testing framework for these issues, but could you please create a model repo with this change so that we can see the change in action?
You also need to apply linting ( You can enable them in your pre-commit hooks as explain here: https://github.com/skops-dev/skops/blob/main/CONTRIBUTING.rst#using-condamamba |
Thanks a lot for the fix, looks neat! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on it 🤗
@rushic24 Lastly, can you post two repositories, one that has a big pipeline plot and another one that has a small one? (given we can't check how Hub looks on our side 😅 just to make sure both cases are fine!) |
Added in the Readme below https://huggingface.co/rushic24/TestPlaygroundSkops |
It looks a bit narrow to me, as in, the container seems to have more space on the right side that we could use, but I'm not sure how easy it is to fix that and if it's not, I'm happy with the solution here. |
@adrinjalali it ends where the right most boundary of other components end, no? Added a photo below: |
How it will look:
Readme example here :- https://huggingface.co/rushic24/TestPlaygroundSkops
Fixes #164