TST Refactor test fixture to be more atomic

[E-Aho]

Small PR to split the responsibilities of the model_card_metadata_from_config fixture to be more atomic, with fixtures that

1. Fetch the Iris data
2. Creates an estimator from the Iris data
3. Pickles estimator in a temp file
4. Create a model card based on other fixtures

Notes:

• Could also now refactor the other places where the iris data is called to use the fixture, or could remove the Iris fetch fetch fixture all together and just call load_iris in each fixture.

Should resolve #166

[merveenoyan]

This looks very neat & clean, thank you ❤️🙂
This is not obligatory but can you check if anything else could be refactored in the main tests, given that we have new fixtures?

[BenjaminBossan]

Looks very good, thanks. @merveenoyan can you confirm that this simplifies the code for your initial concern?

[E-Aho]

This looks very neat & clean, thank you ❤️🙂 This is not obligatory but can you check if anything else could be refactored in the main tests, given that we have new fixtures?

Thanks ❤️ 😄

I can definitely do that, I'll add another commit to this later today to refactor places that can now use these fixtures

[E-Aho]

Updated the skops test that I think @merveenoyan was talking about in the original issue, all now use the fixtures so there's minimal set up in the tests themselves :)

[merveenoyan]

@BenjaminBossan yes it does!

[merveenoyan]

Overall looks very good to me! @BenjaminBossan can you merge if you approve too?

[adrinjalali]

otherwise LGTM