Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC gradio integration #134

Merged
merged 18 commits into from
Sep 21, 2022
Merged

Conversation

merveenoyan
Copy link
Collaborator

@merveenoyan merveenoyan commented Sep 11, 2022

This PR includes documentation for gradio integration.
I added it to plot_hf_hub.py given it's hub related. However, for some reason it can't see there's an example data.

ValueError: No example data found in README.md of skops-ci/hf_hub_example-96069c5a-d82d-4ffd-b1b8-5ac554c7f7ce - Cannot build gradio demo. See the README.md here: https://huggingface.co/scikit-learn/tabular-playground/blob/main/README.md for a reference on how to provide example data to your model.

Also I see in the example there is example input. (the latest model I pushed and the one I got the above error from)
(I also tried on my local, it can build the interface on this Space with model pushed through this tutorial, see
the model and the space)

pinging @freddyaboulton

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merveenoyan

examples/plot_hf_hub.py Outdated Show resolved Hide resolved
@merveenoyan
Copy link
Collaborator Author

@adrinjalali it looks like below:
Ekran Resmi 2022-09-12 16 01 12

also now that we don't have it in examples, I removed it from min dependencies.

@merveenoyan
Copy link
Collaborator Author

@adrinjalali mypy is complaining again 😂

@merveenoyan
Copy link
Collaborator Author

@adrinjalali can you review? can't ask for a re-review

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

docs/hf_hub.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more comments, the rest looks good to me.

docs/hf_hub.rst Outdated Show resolved Hide resolved
docs/hf_hub.rst Outdated Show resolved Hide resolved
examples/plot_hf_hub.py Outdated Show resolved Hide resolved
docs/hf_hub.rst Outdated Show resolved Hide resolved
docs/hf_hub.rst Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
@BenjaminBossan BenjaminBossan merged commit 005bb52 into skops-dev:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants