Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: private access token support #96

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

nover
Copy link
Contributor

@nover nover commented Oct 26, 2022

This PR supersedes #93 by incorporating the changes, but as a non breaking change as originally proposed on the PR.

Commit dfcd93f31a11af6769b2adf1cc4b8586f19b982b from @alexcrowdpharm has been cherry-picked from the fork, and I've updated the code-paths to retain support for the legacy hapikey for now.

@nover nover force-pushed the feat/private-access-token-support branch 2 times, most recently from 0bb23c4 to aad33e0 Compare October 26, 2022 15:27
@nover nover force-pushed the feat/private-access-token-support branch from aad33e0 to 72f7573 Compare October 26, 2022 15:36
@nover nover merged commit e2ade7e into master Oct 26, 2022
@nover nover deleted the feat/private-access-token-support branch October 26, 2022 15:39
@nover nover mentioned this pull request Oct 26, 2022
@alexcrowdpharm
Copy link
Contributor

Thanks for your follow up on this! One thing additional which may not quite be in scope: Using Bearer authorization doesn't necessarily require a token that begins with "pat-". For example, when using the OAuth flow in public apps, the access token value passed into the bearer header will change upon token refresh (and won't be a "pat-" value).

@nover
Copy link
Contributor Author

nover commented Jan 4, 2023

Thanks for your follow up on this! One thing additional which may not quite be in scope: Using Bearer authorization doesn't necessarily require a token that begins with "pat-". For example, when using the OAuth flow in public apps, the access token value passed into the bearer header will change upon token refresh (and won't be a "pat-" value).

Thanks for this little bit 👌
I guess we can actually go about removing the support for the legacy auth system all together now, since it went out of support back in December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants