Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update dependencies and upgrade test projects to .NET 6 #82

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

roycornelissen
Copy link
Collaborator

I thought this project was due for some maintenance on its dependencies.

I also upgraded the test projects to net6.0. Even though aspnetcore3.1 is still officially supported until the end of 2022, I think many projects have already moved on to net5.0 or net6.0.

@nover
Copy link
Contributor

nover commented Jan 26, 2022

Beautiful @roycornelissen - thanks for your continued work on this library :)

I see that appveyor is giving you a hard time. You have to apply a small fix to the appveyor CI file, you can see what I did over here to make it work:
skarpdev/dotnet-version-cli#93

@roycornelissen
Copy link
Collaborator Author

@nover Ah thanks for the heads up, I was already wondering if that would build without changes to the build scripts :)

Fixed!

@roycornelissen
Copy link
Collaborator Author

roycornelissen commented Jan 26, 2022

@nover I might add an extra target to the library for .NET6, because I think that will resolve #83

Update: well, almost, only System.Threading.ThreadPool still has an issue then. But I still added net5.0 and net6.0 as targets.

@nover
Copy link
Contributor

nover commented Feb 3, 2022

@roycornelissen I believe that rapidcore has now been released as 0.27 - would you do the honors of upgrading the dependency in this PR - the w can kill the problem in #83 for good I believe.

@roycornelissen
Copy link
Collaborator Author

@nover Done, updated to latest Nuget dependencies, including RapidCore 0.27 :)

If you're OK, we can merge it

Copy link
Contributor

@nover nover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nover nover merged commit 4a4505b into skarpdev:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants