Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get list of contact lists #63

Merged
merged 8 commits into from
Jan 14, 2021
Merged

Added get list of contact lists #63

merged 8 commits into from
Jan 14, 2021

Commits on Jan 12, 2021

  1. Add files via upload

    davymirfin committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    e7db9d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8681ae6 View commit details
    Browse the repository at this point in the history
  3. Update HubSpotListOfContactsClient.cs

    Added list of contact lists request
    davymirfin committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    f4a5cd8 View commit details
    Browse the repository at this point in the history
  4. Update HubSpotAction.cs

    Added list of contact lists request
    davymirfin committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    9655882 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Update ListOfContactListsHubSpotEntity.cs

    Add DataMember attributes, use PascalCase for names and replace generic names with more specific ones to avoid confusion - these are recomendations of @nover
    davymirfin committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    bc177d7 View commit details
    Browse the repository at this point in the history
  2. Update ListOfContactListsHubSpotEntity.cs

    Syntax errors corrected
    davymirfin committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    488750d View commit details
    Browse the repository at this point in the history
  3. Update ListOfContactListsHubSpotEntity.cs

    Change DateTime properties to string because deserialization of .NET type DateTime in WCF requires some more work e.g. the use of attributes [IgnoreDataMember], [OnSerializing] and [OnDeserialized] along with a private property - see https://stackoverflow.com/questions/18511147/change-default-date-serialization-in-wcf. String datestamps can be easily translated to DateTime explicitly by the caller as necessary. Adding DataMember attributes revealed the problem of deserialization of the DateTime properties (but not before runtime) - it caused exceptions where as without the DataMember attribute, the deserialization failure was not notified.
    davymirfin committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6570617 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Changed the 4 time stamp properties type from string to long and chan…

    …ged each of their names to inclide the postfix "TimeStamp" to imply to the user that unix epoch is the value.
    davymirfin committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    d085ce9 View commit details
    Browse the repository at this point in the history