Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Batch Read for Line Items #60

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Add Batch Read for Line Items #60

merged 1 commit into from
Dec 9, 2020

Conversation

roycornelissen
Copy link
Collaborator

Implements #54: batch-read API for Line Items.

This method returns a somewhat unconventional response compared to other API's: it is a dictionary of LineItemHubSpotEntity where each key is a line item ID, and each value is a LineItemHubSpotEntity. I added DeserializeDictionaryOfEntities<TKey, TEntity>() to the RequestSerializer to facilitate this.

@roycornelissen
Copy link
Collaborator Author

@nover Hi! Back with one more PR 😄 Could you have a look at this? We're using this new method in our system with a private build of this library; would be great if we could continue using it from the official build.

@nover
Copy link
Contributor

nover commented Dec 9, 2020

The hubspot responses never cease to amuse me. Thanks for contributing 👌

@nover nover merged commit 213fbf4 into skarpdev:master Dec 9, 2020
@roycornelissen
Copy link
Collaborator Author

@nover will you release it? Not sure yet how the release process goes for this repo 😊

@nover
Copy link
Contributor

nover commented Dec 9, 2020

Yes sure! It's partly a manual process where I create a tag using dotnet-version-cli and push that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants