Adding data field for reverted calls and estimateGas

[DmytroNazarenko]

Description

This PR adds support of "data" field for reverted eth_call and eth_estimateGas. Example of the response:

{
   "error":{
      "code":3,
      "data":"0x82b42900",
      "message":"EVM revert instruction without description message"
   },
   "id":2327090862,
   "jsonrpc":"2.0"
}

• Field data is a hex-string
• Contains encoded output from reverted call
• If EVM revert contains data, then response will contain error code 3. Otherwise, -32000
• Doesn’t affect tracing

Tests

Unit tests

Added 2 unit tests: JsonRpcSuite/estimate_gas_with_error and JsonRpcSuite/call_with_error

Tracing tests

Tested on historical build by comparing outputs of Geth and skaled

Additional tests

Here is the testing procedure for e2e testing:

1. Deploying contract:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

contract BasicCustomErrorContract {

    // Define custom errors
    error InsufficientBalance();
    error Unauthorized();

    address public owner;


    // Function only callable by the owner
    function ownerOnlyFunction() external {
        revert Unauthorized();
    }

    function requireCall() external {
        require(1 == 0, "Require");
    }

    function revertCall() external {
        revert("Something bad happened");
    }

    function assertCall() external {
        assert(1 == 0);
    }
}

2. Sending eth_calls:

curl SKALED_ENDPOINT -X POST -H "Content-Type: application/json"   --data '{"id":2327090862,"jsonrpc":"2.0","method":"eth_call","params":[{"data":"0xe021c206","from":"0xa68F946090c600eDa6f139783077EE802Afeb990","to":"0x62815b8b66a91fef35d7950f83c04da6a64508c2","value":"0x0"},"latest"]}'
curl SKALED_ENDPOINT -X POST -H "Content-Type: application/json"   --data '{"id":2327090862,"jsonrpc":"2.0","method":"eth_call","params":[{"data":"0xf38fb65b","from":"0xa68F946090c600eDa6f139783077EE802Afeb990","to":"0x62815b8b66a91fef35d7950f83c04da6a64508c2","value":"0x0"},"latest"]}'
curl SKALED_ENDPOINT -X POST -H "Content-Type: application/json"   --data '{"id":2327090862,"jsonrpc":"2.0","method":"eth_call","params":[{"data":"0x068d492b","from":"0xa68F946090c600eDa6f139783077EE802Afeb990","to":"0x62815b8b66a91fef35d7950f83c04da6a64508c2","value":"0x0"},"latest"]}'
curl SKALED_ENDPOINT -X POST -H "Content-Type: application/json"   --data '{"id":2327090862,"jsonrpc":"2.0","method":"eth_call","params":[{"data":"0x4bc55aed","from":"0xa68F946090c600eDa6f139783077EE802Afeb990","to":"0x62815b8b66a91fef35d7950f83c04da6a64508c2","value":"0x0"},"latest"]}'

3. Receiving responses:

{"error":{"code":3,"data":"0x82b42900","message":"EVM revert instruction without description message"},"id":2327090862,"jsonrpc":"2.0"}
{"error":{"code":3,"data":"0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000016536f6d657468696e67206261642068617070656e656400000000000000000000","message":"Something bad happened"},"id":2327090862,"jsonrpc":"2.0"}
{"error":{"code":3,"data":"0x4e487b710000000000000000000000000000000000000000000000000000000000000001","message":"EVM revert instruction without description message"},"id":2327090862,"jsonrpc":"2.0"}
{"error":{"code":3,"data":"0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000075265717569726500000000000000000000000000000000000000000000000000","message":"Require"},"id":2327090862,"jsonrpc":"2.0"}

4. Repeating p.3-4 for eth_estimateGas

Performance Impact

All changes are inside JSON RPC API modules, so performance is not affected

[github-actions]

SUGGESTIONS BEFORE MERGE:

1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
3. Edit VERSION file appropriately to your changes!
   See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

[kladkogex]

1 We need to find the corresponding code in geth to make sure we are doing exactly doing for this field

2. Also we need to understand how does this new field affect tracing. Where does it show in traces? To do this, one needs to do geth trace and compare

Our strategy needs to be 100% compatible with geth