feat(extensions): Add _brs_.testData associative array #646
Conversation
lkipke
added
documentation
There was a problem hiding this comment.
Thanks for tackling this, @Vasya-M! It looks like _brs_ persists across Interpreter instances, which may be the motivation behind exposing resetTestData() outside of this module. I'm curious if we could ensure each Interpreter instance gets its own copy of _brs_ and solve this problem without having to export a new function that consumers might forget to call!
test/extensions/testData.test.js
Outdated
| .get(new BrsString("testData")); | ||
| expect(testData.elements.size).toBe(1); | ||
|
|
||
| brs.resetTestData(); // will clear testData for next new Interpreter instances |
There was a problem hiding this comment.
Do we want the _brs_.testData to persist across interpreter instances? IIRC there's only one created as part of roca anyway. We'll still want this type of behavior, but perhaps simpler solution would be for each Interpreter instance to get its own copy of the _brs_ extensions 🤔
src/index.ts
Outdated
| @@ -16,6 +16,7 @@ import { | |||
| } from "./componentprocessor"; | |||
| import { Parser } from "./parser"; | |||
| import { Interpreter, ExecutionOptions, defaultExecutionOptions } from "./interpreter"; | |||
| export { resetTestData } from "./extensions"; | |||
There was a problem hiding this comment.
I'm not sure that this needs to be exposed from the root of the module. If it does need to be exposed, I'd like for us to find (or add) a new property to put it on instead of it being a sibling of brs.lexer, brs.parser, brs.types, etc. Those are all very low-level concepts, and resetTestData doesn't match those 😃
| @@ -230,6 +231,7 @@ export async function createExecuteWithScope( | |||
| interpreter.errors = []; | |||
|
|
|||
| return (filenames: string[], args: BrsTypes.BrsType[]) => { | |||
| resetTestData(); | |||
There was a problem hiding this comment.
I like this solution better than exporting it!
sjbarag
changed the title
testData to _brs_ 
fix for issue #623
added
testDatato_brs_objectexported new method
resetTestDatafor cleaningtestDatabefore runing test suites(test files)linked roca PR: hulu/roca#88