Merge pull request #256 from sitkoru/update-api

feat: remove not supported consts
sitkoru · Jan 31, 2022 · be1e130 · be1e130
2 parents 956926d + cd081a5
commit be1e130
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/src/services/campaigns/CampaignsService.php b/src/services/campaigns/CampaignsService.php
@@ -208,6 +208,7 @@ public function toUpdateEntities(array $entities): array
         foreach ($converted as $campaign) {
             if ($campaign->TextCampaign && $campaign->TextCampaign->Settings) {
                 foreach ($campaign->TextCampaign->Settings as $i => $setting) {
+                    TextCampaignSettingsEnum::checkValue($setting->Option);
                     if (TextCampaignSettingsEnum::isGetOnly($setting->Option)) {
                         unset($campaign->TextCampaign->Settings[$i]);
                     }
@@ -240,6 +241,7 @@ public function toUpdateEntities(array $entities): array
             }
             if ($campaign->MobileAppCampaign && $campaign->MobileAppCampaign->Settings) {
                 foreach ($campaign->MobileAppCampaign->Settings as $i => $setting) {
+                    MobileAppCampaignSettingsEnum::checkValue($setting->Option);
                     if (MobileAppCampaignSettingsEnum::isGetOnly($setting->Option)) {
                         unset($campaign->MobileAppCampaign->Settings[$i]);
                     }

diff --git a/src/services/campaigns/enum/MobileAppCampaignSettingsEnum.php b/src/services/campaigns/enum/MobileAppCampaignSettingsEnum.php
@@ -3,6 +3,7 @@
 namespace directapi\services\campaigns\enum;
 
 use directapi\components\Enum;
+use directapi\exceptions\DirectApiException;
 
 class MobileAppCampaignSettingsEnum extends Enum
 {
@@ -33,4 +34,14 @@ public static function isGetOnly(MobileAppCampaignSettingsEnum $value): bool
         }
         return false;
     }
+
+    /**
+     * @throws \Exception
+     */
+    public static function checkValue(MobileAppCampaignSettingsEnum $value)
+    {
+        if ($value == self::MAINTAIN_NETWORK_CPC) {
+            throw new DirectApiException(self::MAINTAIN_NETWORK_CPC . " is deprecated");
+        }
+    }
 }
diff --git a/src/services/campaigns/enum/TextCampaignSettingsEnum.php b/src/services/campaigns/enum/TextCampaignSettingsEnum.php
@@ -3,6 +3,7 @@
 namespace directapi\services\campaigns\enum;
 
 use directapi\components\Enum;
+use directapi\exceptions\DirectApiException;
 
 class TextCampaignSettingsEnum extends Enum
 {
@@ -40,4 +41,14 @@ public static function isGetOnly(TextCampaignSettingsEnum $value): bool
         }
         return false;
     }
+
+    /**
+     * @throws \Exception
+     */
+    public static function checkValue(TextCampaignSettingsEnum $value)
+    {
+        if ($value == self::MAINTAIN_NETWORK_CPC) {
+            throw new DirectApiException(self::MAINTAIN_NETWORK_CPC . " is deprecated");
+        }
+    }
 }