Develop #3
Merged
Develop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 10, 2024 16:25
…e solved.
->
src/lib/exercises/src/hackerrank/warmup/simple_array_sum.cpp:20:41: performance: Function parameter 'ar' should be passed by const reference. [passedByValue]
int simpleArraySum(std::vector<int> ar) {
…e solved.
->
src/lib/exercises/src/hackerrank/warmup/simple_array_sum.cpp:24:19: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]
accum += i;
^
->
src/tests/unit/lib/foo.test.cpp:5:0: style: The function 'TEST_CASE' is never used. [unusedFunction]
TEST_CASE("adding numbers work", "[foo]")
^
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 5 -2
Branches 1 0 -1
=========================================
- Hits 7 5 -2 ☔ View full report in Codecov by Sentry. |
sir-gon
pushed a commit
that referenced
this pull request
Sep 23, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 23, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 24, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 24, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 24, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 24, 2024
sir-gon
pushed a commit
that referenced
this pull request
Sep 24, 2024
sir-gon
added a commit
that referenced
this pull request
Sep 24, 2024
[Hacker Rank]: Project Euler #3: Largest prime factor. Solved ✓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.