feat: pdf argument #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkaroid
requested changes
Sep 11, 2022
There was a problem hiding this comment.
Hey thanks, everything looks good for me, It's all tested already? I have tested nhentai and pururin that was beautiful.
Small changes here:
- Bump new release to:
__version__ = "3.0.14"please? - Could you apply
blackon your commit? A code formatter like prettier then runblack tomoe/
| @@ -24,6 +24,9 @@ asmhentai: | |||
|
|
|||
| bulk: | |||
| tomoe --bulk doujin.json | |||
|
|
|||
| pdf: | |||
There was a problem hiding this comment.
I see a new target testing here, but no new workflows was added, If you want to add testing for pdf could you add the new .github/workflows ci too?
|
PR updated @sinkaroid |
sinkaroid
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--pdfto render the pdf file without having to interact with theinputimeoutdialogREADME.mdfileIssue: #3