Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Port bounding-box logic from R to Python #1648

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 31, 2023

Issue and/or context: Issue #1522; R PRs ##1513, #1644, with additional logic for append mode which isn't in R yet (see #1630). Also involves #1434 which will be a follow-on PR to this one.

Changes:

Notes for Reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage is 98.21% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
apis/python/src/tiledbsoma/_sparse_nd_array.py 98.21%

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl requested review from aaronwolen and removed request for mlin September 1, 2023 13:10
@johnkerl
Copy link
Member Author

johnkerl commented Sep 1, 2023

@aaronwolen @mojaveazure @thetorpedodog ping 🙏

@johnkerl
Copy link
Member Author

johnkerl commented Sep 1, 2023

Thanks @aaronwolen !

@johnkerl johnkerl merged commit a21e43f into main Sep 1, 2023
5 checks passed
@johnkerl johnkerl deleted the kerl/python-bounding-box branch September 1, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants