Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Occasional mis-shaping issue for to_h5ad/to_anndata on obsm/varm #1434

Closed
johnkerl opened this issue May 31, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working python-api

Comments

@johnkerl
Copy link
Member

johnkerl commented May 31, 2023

Using the following dataset:
https://cellxgene.cziscience.com/collections/2b02dff7-e427-4cdc-96fb-c0f354c099aa

Ingest this as a SOMA using tiledbsoma.io.from_h5ad. Then outgest using tiledbsoma.io.to_h5ad. Resulting error:

tiledbsoma._exception.SOMAError: internal error: encountered non-rectangular varm[PCs]: 22068 does not divide 46200

For this dataset:

  • nobs is 32458
  • nvar is 22068
  • varm/PCs is 22038 tall (not 22068) x 30 wide

The to_h5ad is being unit-tested in the repo, but, for data wherein varm height matches nvar. We need to deep-dive what it means for this dataset for varm height to differ from nvar, and, if this is something that's not downright pathological about this particular dataset, find out how to handle it more elegantly.

A good solution here might benefit from the bounding-box-as-metadata topic discussed on #1445.

@johnkerl johnkerl added bug Something isn't working python-api labels May 31, 2023
@johnkerl johnkerl changed the title [python] Occasional mis-shaping issue for to_h5ad on varm/PCs [python] Occasional mis-shaping issue for to_h5ad/to_anndata on varm/PCs Aug 29, 2023
@johnkerl johnkerl changed the title [python] Occasional mis-shaping issue for to_h5ad/to_anndata on varm/PCs [python] Occasional mis-shaping issue for to_h5ad/to_anndata on obsm/varm Aug 30, 2023
@johnkerl
Copy link
Member Author

Long since resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python-api
Projects
None yet
Development

No branches or pull requests

2 participants