-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Append-mode pre-check logic #1554
Conversation
8776822
to
88809dc
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
==========================================
+ Coverage 91.30% 91.41% +0.11%
==========================================
Files 30 31 +1
Lines 2552 2668 +116
==========================================
+ Hits 2330 2439 +109
- Misses 222 229 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
88809dc
to
f15b43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the structure of this code is good; I do have some suggestions and a few concerns about the API right now, though.
@thetorpedodog ready for round two |
837760e
to
a755401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the few comments below, looks good to me style-wise. The logic seems reasonable but I’m not super familiar; you may wish to get another reviewer to give that a once-over (but not mandatory).
@aaronwolen @mojaveazure any final concerns before I merge? This is of course a multi-PR (at least 3-PR) WIP and I'm happy to take feedback before or after the merge ... |
Merging -- happy to take belated feedback as a follow-on PR |
Issue and/or context:
Tracking issue: #1278
Changes:
Signature
class which will be used for append-mode pre-check on an upcoming PRNotes for Reviewer: