Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Append-mode pre-check logic #1554

Merged
merged 14 commits into from
Jul 31, 2023
Merged

[python] Append-mode pre-check logic #1554

merged 14 commits into from
Jul 31, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jul 27, 2023

Issue and/or context:

Tracking issue: #1278

Changes:

  • Create the Signature class which will be used for append-mode pre-check on an upcoming PR
  • Unit-test that

Notes for Reviewer:

  • This is a split-out PR -- created for mercifulness to reviewers -- as a line-count reduction from raw material on [WIP] [python] Append-mode sketching #1498.
  • Question for @aaronwolen @mojaveazure : If an input file has raw and non-raw data do we want them both to be ingested? Or just one or the other? This is actually a design question -- which I'll also put in our tracking doc.

@johnkerl johnkerl changed the title [python] Append-mode pre-check logic [WIP] [WIP] [python] Append-mode pre-check logic Jul 27, 2023
@johnkerl johnkerl force-pushed the kerl/append-pre-check branch 3 times, most recently from 8776822 to 88809dc Compare July 27, 2023 16:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 93.98% and project coverage change: +0.11% 🎉

Comparison is base (ce57a9d) 91.30% compared to head (c84d114) 91.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1554      +/-   ##
==========================================
+ Coverage   91.30%   91.41%   +0.11%     
==========================================
  Files          30       31       +1     
  Lines        2552     2668     +116     
==========================================
+ Hits         2330     2439     +109     
- Misses        222      229       +7     
Flag Coverage Δ
python 91.41% <93.98%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ython/src/tiledbsoma/io/registration/signatures.py 92.98% <92.98%> (ø)
apis/python/src/tiledbsoma/_arrow_types.py 94.66% <100.00%> (+1.56%) ⬆️
apis/python/src/tiledbsoma/io/ingest.py 84.72% <100.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnkerl johnkerl changed the title [WIP] [python] Append-mode pre-check logic [python] Append-mode pre-check logic Jul 27, 2023
@johnkerl johnkerl marked this pull request as ready for review July 27, 2023 16:09
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the structure of this code is good; I do have some suggestions and a few concerns about the API right now, though.

apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_arrow_types.py Show resolved Hide resolved
@johnkerl
Copy link
Member Author

@thetorpedodog ready for round two

Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the few comments below, looks good to me style-wise. The logic seems reasonable but I’m not super familiar; you may wish to get another reviewer to give that a once-over (but not mandatory).

apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/io/registration/signatures.py Outdated Show resolved Hide resolved
@johnkerl
Copy link
Member Author

@aaronwolen @mojaveazure any final concerns before I merge? This is of course a multi-PR (at least 3-PR) WIP and I'm happy to take feedback before or after the merge ...

@johnkerl
Copy link
Member Author

Merging -- happy to take belated feedback as a follow-on PR

@johnkerl johnkerl merged commit 86b0298 into main Jul 31, 2023
5 checks passed
@johnkerl johnkerl deleted the kerl/append-pre-check branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants