Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [python] Append-mode sketching #1498

Closed
wants to merge 9 commits into from
Closed

[WIP] [python] Append-mode sketching #1498

wants to merge 9 commits into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jun 22, 2023

This is a draft PR, with no reviewers, explicitly marked as not ready for review.

Please do not review this PR.

It is posted here solely for bus-factor risk-reduction, temporarily cloud-hosting some incomplete prototyping work in support of an upcoming second round of design discussion.

Context: #1278

Split-out PRs from this raw material:

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage: 50.12% and project coverage change: +20.92% 🎉

Comparison is base (1d26a56) 64.66% compared to head (8fb284a) 85.58%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1498       +/-   ##
===========================================
+ Coverage   64.66%   85.58%   +20.92%     
===========================================
  Files         104       34       -70     
  Lines        8686     2942     -5744     
===========================================
- Hits         5617     2518     -3099     
+ Misses       3069      424     -2645     
Flag Coverage Δ
python 85.58% <50.12%> (-5.72%) ⬇️
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ython/src/tiledbsoma/io/registration/signatures.py 27.00% <27.00%> (ø)
...ledbsoma/io/registration/ambient_label_mappings.py 57.22% <57.22%> (ø)
apis/python/src/tiledbsoma/io/ingest.py 82.40% <62.06%> (-2.56%) ⬇️
...thon/src/tiledbsoma/io/registration/id_mappings.py 82.35% <82.35%> (ø)
.../python/src/tiledbsoma/io/registration/__init__.py 100.00% <100.00%> (ø)

... and 74 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnkerl johnkerl force-pushed the kerl/jidmap2 branch 8 times, most recently from 61ca593 to 500a71d Compare June 22, 2023 21:23
@johnkerl johnkerl force-pushed the kerl/jidmap2 branch 5 times, most recently from 003c4a5 to a31fab7 Compare June 24, 2023 00:44
@johnkerl johnkerl force-pushed the kerl/jidmap2 branch 2 times, most recently from c774106 to c2180d8 Compare July 9, 2023 15:53
@johnkerl johnkerl force-pushed the kerl/jidmap2 branch 13 times, most recently from 3a0e86b to 8fb284a Compare July 26, 2023 23:21
@johnkerl johnkerl changed the title [python] Append-mode sketching [WIP / not ready for review / please do not review] [WIP] [python] Append-mode sketching Jul 27, 2023
@johnkerl
Copy link
Member Author

johnkerl commented Aug 9, 2023

Replaced by #1554 #1556 #1587

@johnkerl johnkerl closed this Aug 9, 2023
@johnkerl johnkerl deleted the kerl/jidmap2 branch November 7, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants