Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Exact): fix support for Date in union #902

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(Exact): fix support for Date in union #902

merged 2 commits into from
Jul 2, 2024

Conversation

zorji
Copy link
Contributor

@zorji zorji commented Jun 30, 2024 •
edited by sindresorhus
Loading

What's changed

  • Use JsonObject to only apply Exact check for simple object. Type from a class should rely on the native TypeScript check

Why?

@zorji zorji mentioned this pull request Jun 30, 2024
Closed
@zorji zorji marked this pull request as ready for review June 30, 2024 11:44
@sindresorhus sindresorhus merged commit d89a709 into sindresorhus:main Jul 2, 2024
8 checks passed
@zorji zorji deleted the fix-exact-with-date-type branch July 3, 2024 02:03
@nlynzaad nlynzaad mentioned this pull request Jul 8, 2024
Closed
@zorji zorji mentioned this pull request Jul 9, 2024
Merged
@spudly spudly mentioned this pull request Jul 24, 2024
Closed
@lwih lwih mentioned this pull request Aug 1, 2024
Merged
@Sec-ant Sec-ant mentioned this pull request Aug 7, 2024
Open
@lwih lwih mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 10, 2024
Open
Open
@spudly spudly mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exact does not work as expected with type involving Date and union
2 participants
@zorji @sindresorhus