Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New macOS binary, signed with Node.js Foundation identity and hardened #16

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

rvagg
Copy link
Contributor

@rvagg rvagg commented Jan 30, 2020

Ref: sindresorhus/macos-terminal-size#3
Ref: nodejs/node#31459

$ codesign -dv vendor/macos/term-size
Executable=/Users/rvagg/git/term-size/vendor/macos/term-size
Identifier=term-size
Format=Mach-O thin (x86_64)
CodeDirectory v=20500 size=277 flags=0x10000(runtime) hashes=3+2 location=embedded
Signature size=8986
Timestamp=30 Jan 2020 at 9:29:23 pm
Info.plist=not bound
TeamIdentifier=HX7739G8FX
Runtime Version=10.14.0
Sealed Resources=none
Internal requirements count=1 size=172

Have also tested the binary on a 10.10 machine and it's 👍.

(for puzzled onlookers: this is being done because this is bundled with npm and we need to notarize our packages which includes having all executable binaries signed)


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus sindresorhus merged commit 723563c into sindresorhus:master Jan 30, 2020
ruyadorno added a commit to ruyadorno/cli that referenced this pull request Mar 23, 2020
Upstream node is patching `term-size` in order to avoid failing release
builds, see: nodejs/node#32403

Given that npm@6 has to support node6 and that dependency chain is long
enough, along with many major bumps dropping node6 along the way. I
propose we patch it here same as node upstream.

- ref: sindresorhus/terminal-size#16
ruyadorno added a commit to npm/cli that referenced this pull request Mar 24, 2020
Upstream node is patching `term-size` in order to avoid failing release
builds, see: nodejs/node#32403

Given that npm@6 has to support node6 and that dependency chain is long
enough, along with many major bumps dropping node6 along the way. I
propose we patch it here same as node upstream.

- ref: sindresorhus/terminal-size#16

PR-URL: #1053
Credit: @ruyadorno
Close: #1053
Reviewed-by: @ruyadorno
@rvagg rvagg deleted the rvagg/signed-macos-binary branch October 4, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants