Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pMapIterable when accepting async values in an iterator #69

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

noamokman
Copy link
Contributor

Hey,
Changed the shared input to include a promise as this is the sample in the basic usage.
I also fixed pMapIterable to await on values as it's type allows Iterator<Element | Promise<Element>>.
The tests cover this fix.

Related to sindresorhus/p-filter#8

Thanks!

@sindresorhus
Copy link
Owner

// @Richienb

@Richienb
Copy link
Contributor

Seems fine but would appreciate some type tests for all four (?) types of input

@noamokman
Copy link
Contributor Author

Sure I'll add it now

@noamokman
Copy link
Contributor Author

@Richienb please take another look 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants