Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On WSL, invoke app like on Linux #295

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

kazarmy
Copy link
Contributor

@kazarmy kazarmy commented Jan 29, 2023

This pr handles the app property on WSL the same as on Linux. The reason being that while one can invoke Windows PowerShell (or even a Windows browser) from the WSL shell, afaik one can't use Windows PowerShell or the Windows START command to run WSL binaries. They can be run directly from the WSL shell though like on Linux.

This pr also provides a way to fixes #293, namely by setting the app.name property to a WSL browser binary like google-chrome.

@sindresorhus sindresorhus merged commit 4cf1a6d into sindresorhus:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running open module inside Ubuntu on wsl2 always opens browser in windows
2 participants