Fix error.stdout|stderr|all
type when encoding
option is used
#652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
encoding
option is not correctly applied toerror.stdout|stderr|all
. Namely:encoding
isbuffer
,error.stdout|stderr|all
is anArrayBuffer
instead of anUint8Array
encoding
is something else likehex
,error.stdout|stderr|all
is a Node.jsBuffer
instead of a stringundefined
This is because the encoding logic is applied after
get-stream
has succeeded, but it is not applied onerror.bufferedData
, i.e. whenget-stream
has failed or been aborted.This PR fixes this.