Add table filter functionality #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great idea, and your implementation is slick. However I'm thinking about a filter similar to the one found in the ListView. Also a couple of things are missing from your implementation like responsive UI and internationalization support. I'll probably pull your code and work on that, also note that this project uses tabs for indentation. |
|
@simov you should setup an editorconfig file for helping to contribute. |
|
@simov I can make those changes if you want, otherwise feel free to do that. |
|
Agreed about the editorconfig file. I'll take a look at this one. |
|
Hey @knownasilya Check this out 27f03f4 It was easier for me to implement it from scratch, that's why there is no merge. I used your idea though, credits in the commit message 🍻 |
TKimura416
added a commit
to TKimura416/Node_WebAdmin
that referenced
this pull request
Sep 2, 2016
- closes simov/express-admin#73 - thanks to @knownasilya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter for tables, especially useful for lots of tables.