Don't return 500 if mirror url contains special chars (go-gitea#31859)

Fix go-gitea#31640
sillyguodong · Aug 21, 2024 · d158472 · d158472
1 parent d1426de
commit d158472
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/routers/web/repo/setting/setting.go b/routers/web/repo/setting/setting.go
@@ -240,7 +240,8 @@ func SettingsPost(ctx *context.Context) {
 
 		remoteAddress, err := util.SanitizeURL(form.MirrorAddress)
 		if err != nil {
-			ctx.ServerError("SanitizeURL", err)
+			ctx.Data["Err_MirrorAddress"] = true
+			handleSettingRemoteAddrError(ctx, err, form)
 			return
 		}
 		pullMirror.RemoteAddress = remoteAddress
@@ -401,7 +402,8 @@ func SettingsPost(ctx *context.Context) {
 
 		remoteAddress, err := util.SanitizeURL(form.PushMirrorAddress)
 		if err != nil {
-			ctx.ServerError("SanitizeURL", err)
+			ctx.Data["Err_PushMirrorAddress"] = true
+			handleSettingRemoteAddrError(ctx, err, form)
 			return
 		}