Make document state available during class's post init #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
class-post-init
branch
from
b2f6a22
to
71336b9
Compare
|
I'm going to go ahead with this "fix". It still isn't ideal, but whether we're munging some global state variable from the inputter or the class doesn't seem to be consequential. The right answer is to stop munging global state, but this makes more sense to me and should make eventually refactoring it out entirely that much easier to accomplish. I do not think this change is the right way to "fix" the issue in #2083, that should still be done with a preamble. But it does "fix" the issue in that we document what the related API is for. |
alerque
added
bug
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2083, although I'm unsure if this is actually a fundamental improvement or if it just makes a bigger mess of variable scopes. Catching the error and suggesting preambels might be a better route.