Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem caused by not handling error #565

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

Ranxy
Copy link
Contributor

@Ranxy Ranxy commented Jun 20, 2024

During usage, we encountered a Panic error:

error: interface conversion: driver.Rows is nil, not *go_ora.DataSet
runtime.panicdottypeE
    /usr/local/go/src/runtime/iface.go:262
runtime.panicdottypeI
    /usr/local/go/src/runtime/iface.go:272
github.com/sijms/go-ora/v2.(*Connection).QueryRowContext
    /go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.19/connection.go:1083
github.com/sijms/go-ora/v2.(*Connection).getDBTimeZone
    /go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.19/connection.go:509
github.com/sijms/go-ora/v2.(*Connection).dataTypeNegotiation
    /go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.19/connection.go:1289

After investigation, it seems that the issue was caused by not handling the error in the code.
Therefore, submitted this PR to resolve the problem and also fixed #564

@sijms sijms merged commit 83fd55e into sijms:master Jul 7, 2024
1 of 3 checks passed
@sijms
Copy link
Owner

sijms commented Jul 7, 2024

thanks for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

has a panic error
2 participants