clean up unused cluster-wide IP and dns WRR configs #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
Jul 24, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
Gregory-Pereira
pushed a commit
to Gregory-Pereira/scaffolding
that referenced
this pull request
Nov 16, 2023
* clean up unused cluster-wide IP and dns WRR configs Signed-off-by: Bob Callaway <bcallaway@google.com> * fix tf fmt lint Signed-off-by: Bob Callaway <bcallaway@google.com> --------- Signed-off-by: Bob Callaway <bcallaway@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the variables for a single cluster-wide IP for load balancing and the variables used to shift traffic during the LB migration.
this also updates the timestamp terraform to match the other services, even though we don't deploy this in p-g-i