-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to use go1.20 #566
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
will require a change to update the checks,doing that |
ci checks changes: sigstore/community#238 |
ci checks updated |
- v1.23.x | ||
- v1.24.x | ||
- v1.25.x | ||
- v1.23.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we drop 1.23?
its eol on feb 28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, well, this is a bit tricky because I know some folks have asked fairly recently for policy-controller support on something like 1.21, 1.22 so keeping testing as long as we can is something that I think would be nice. If there are breaking changes that would require making changes, then we can revisit them on case-by-case basis. Does that make sense? But I don't feel super strongly, just think it would be nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. thanks
we might want to come up with a k8s support policy, just so i dont ask silly questions like this. or should we follow the knative k8s support policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, it's a great question that we should have an answer to. Tricky bit is that indeed for us to run on older versions because we're relying on knative we will need to use the ENV variable to say it's ok to run. So 🤷
Summary