Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to use go1.20 #566

Merged
merged 1 commit into from
Mar 7, 2023
Merged

upgrade to use go1.20 #566

merged 1 commit into from
Mar 7, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 6, 2023

Summary

  • upgrade to use go1.20

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2023

will require a change to update the checks,doing that

@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2023

ci checks changes: sigstore/community#238

@cpanato
Copy link
Member Author

cpanato commented Mar 7, 2023

ci checks updated

@vaikas vaikas merged commit d289e44 into sigstore:main Mar 7, 2023
- v1.23.x
- v1.24.x
- v1.25.x
- v1.23.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we drop 1.23?
its eol on feb 28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, well, this is a bit tricky because I know some folks have asked fairly recently for policy-controller support on something like 1.21, 1.22 so keeping testing as long as we can is something that I think would be nice. If there are breaking changes that would require making changes, then we can revisit them on case-by-case basis. Does that make sense? But I don't feel super strongly, just think it would be nice :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. thanks

we might want to come up with a k8s support policy, just so i dont ask silly questions like this. or should we follow the knative k8s support policy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in a follow up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, it's a great question that we should have an answer to. Tricky bit is that indeed for us to run on older versions because we're relying on knative we will need to use the ENV variable to say it's ok to run. So 🤷

@cpanato cpanato deleted the update-go-120 branch March 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants