add fulcio-grpc as knative service #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
@vaikas I think once this is merged (assuming you're OK with it), we'll need to cut 0.4.13 release and then bump the references inline up to 0.4.13 and then cut another release or update the tag? |
|
Thanks @bobcallaway I have no problem at all running parallel Fulcio, though shortly I'd like to still investigate the use the same port for both grpc/http :) Something like this (that just doesn't rely on HTTP/2 for muxing): |
vaikas
approved these changes
Nov 8, 2022
| @@ -20,7 +20,7 @@ spec: | |||
| # This doesn't actually use Kubernetes credentials, so don't mount them in. | |||
| automountServiceAccountToken: false | |||
| containers: | |||
| - image: gcr.io/projectsigstore/fulcio@sha256:61081295a8f75ed7537b5d1f8c7320e078dc00e4562c0bf605fbefa062c690de # v0.5.3 | |||
| - image: gcr.io/projectsigstore/fulcio@sha256:27c6e4fe64a72a537c133452d9c8e0518944d1d69aeee5e7ef8a9fbe70b8b5d3 # v1.0.0 | |||
cpanato
reviewed
Nov 10, 2022
| # This doesn't actually use Kubernetes credentials, so don't mount them in. | ||
| automountServiceAccountToken: false | ||
| containers: | ||
| - image: gcr.io/projectsigstore/fulcio@sha256:27c6e4fe64a72a537c133452d9c8e0518944d1d69aeee5e7ef8a9fbe70b8b5d3 # v1.0.0 |
There was a problem hiding this comment.
why not use gcr.io/projectsigstore/fulcio:v1.0.0@sha256:27c6e4fe64a72a537c133452d9c8e0518944d1d69aeee5e7ef8a9fbe70b8b5d3 and drop the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Callaway bcallaway@google.com
Summary
Release Note
Documentation