Add back support for RSA for legacy deployed CTLogs. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
| if err != nil { | ||
| return nil, fmt.Errorf("failed to parse private key PEM: %w", err) | ||
| return nil, fmt.Errorf("failed to decrypt private PEMKeyFile: %w", err) |
There was a problem hiding this comment.
Does this need to not return in order to fall through to trying to decode pkcs8?
There was a problem hiding this comment.
Sorry, I don't understand what you mean. Even in the legacy cases, these were always encrypted but it was just that the keys created were just created as RSA keys. Does that make sense? I think this should always fail if decrypt fails because the keys handed to CTLog must be encrypted.
There was a problem hiding this comment.
Yep sorry, was thinking this was doing a different operation. This looks good!
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
haydentherapper
approved these changes
Sep 9, 2022
priyawadhwa
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
While I started playing around with testing the newly created config library, realized that we need to still be able to
deal with legacy configs (created with the RSA private key). So handle them both + tests for unmarshaling/round-tripping.
Release Note
Documentation