add dns resources to service-level terraform #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4leung4
reviewed
Sep 6, 2022
k4leung4
reviewed
Sep 6, 2022
vaikas
reviewed
Sep 20, 2022
| resource "google_dns_record_set" "A_ctfe" { | ||
| name = "ctfe.${var.dns_domain_name}" | ||
| type = "A" | ||
| ttl = 60 |
There was a problem hiding this comment.
This seems awfully short to me, but my dns-fu is super old :)
vaikas
previously approved these changes
Sep 21, 2022
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
vaikas
approved these changes
Sep 21, 2022
deobieta
pushed a commit
to deobieta/scaffolding
that referenced
this pull request
Sep 21, 2022
* add dns resources to service-level terraform Signed-off-by: Bob Callaway <bcallaway@google.com> * remove duplicate resource Signed-off-by: Bob Callaway <bcallaway@google.com> * add missing var Signed-off-by: Bob Callaway <bcallaway@google.com> * fix spacing Signed-off-by: Bob Callaway <bcallaway@google.com> * remove unused region var Signed-off-by: Bob Callaway <bcallaway@google.com> * remove region reference Signed-off-by: Bob Callaway <bcallaway@google.com> Signed-off-by: Bob Callaway <bcallaway@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Callaway bcallaway@google.com