Truncate files if they exist prior to extraction from archive #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Slavek Kabrda <bkabrda@redhat.com>
bobcallaway
approved these changes
Aug 29, 2024
bouskaJ
pushed a commit
to securesign/scaffolding
that referenced
this pull request
Aug 30, 2024
…re#1245) Signed-off-by: Slavek Kabrda <bkabrda@redhat.com>
bouskaJ
added a commit
to securesign/scaffolding
that referenced
this pull request
Aug 30, 2024
Truncate files if they exist prior to extraction from archive (sigstore#1245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we're uncompressing a file, when the target file already exists, right now it's not truncated. This means that when we're writing less content than what the file already has, the rest of the old content would remain in the file. This PR fixes that by truncating the file when we open it.