fix shellcheck (#376)

* fix shellcheck Signed-off-by: cpanato <ctadeu@gmail.com> * fix missing export Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: cpanato <ctadeu@gmail.com>
sigstore · Sep 23, 2022 · 43b86d0 · 43b86d0
1 parent bb050cf
commit 43b86d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -30,7 +30,7 @@ sign-test-images:
 .PHONY: sign-release-images
 sign-release-images: sign-test-images
 	$(foreach artifact,$(artifacts), \
-		GIT_HASH=$(GIT_HASH) GIT_VERSION=$(GIT_TAG) ARTIFACT=imagerefs-$(artifact); ./scripts/sign-release-images.sh \
+		echo "Signing $(artifact)"; export GIT_HASH=$(GIT_HASH) GIT_VERSION=$(GIT_TAG) ARTIFACT=imagerefs-$(artifact); ./scripts/sign-release-images.sh \
 	)
 
 .PHONY: release-images

diff --git a/scripts/sign-release-images.sh b/scripts/sign-release-images.sh
@@ -27,4 +27,5 @@ if [[ ! -f $ARTIFACT ]]; then
 fi
 
 echo "Signing images with Keyless..."
-cosign sign --timeout 5m --force -a GIT_HASH="$GIT_HASH" -a GIT_VERSION="$GIT_VERSION" $(cat $ARTIFACT)
+readarray -t file_args < <(cat "$ARTIFACT")
+cosign sign --timeout 5m --force -a GIT_HASH="$GIT_HASH" -a GIT_VERSION="$GIT_VERSION" "${file_args[@]}"