Skip to content

Commit

Permalink
fix lint errors
Browse files Browse the repository at this point in the history
Signed-off-by: Bob Callaway <bcallaway@google.com>
  • Loading branch information
bobcallaway committed Oct 7, 2024
1 parent 70315b3 commit bbc5216
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/api-docs/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func astFrom(filePath string) *doc.Package {
}

m[filePath] = f
apkg, _ := ast.NewPackage(fset, m, nil, nil) //nolint:errcheck
apkg, _ := ast.NewPackage(fset, m, nil, nil) //nolint:staticcheck

return doc.New(apkg, "", 0)
}
Expand Down
10 changes: 8 additions & 2 deletions pkg/tuf/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ func Uncompress(src io.Reader, dst string) error {
}
// Write out files
case tar.TypeReg:
fileToWrite, err := os.OpenFile(target, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode))
if header.Mode < 0 && int64(uint32(header.Mode)) != header.Mode { //nolint:gosec // disable G115
return errors.New("invalid mode value in tar header")
}
fileToWrite, err := os.OpenFile(target, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode)) //nolint:gosec // disable G115
if err != nil {
return err
}
Expand Down Expand Up @@ -213,9 +216,12 @@ func UncompressMemFS(src io.Reader, stripPrefix string) (fs.FS, error) {
if err != nil && err != io.EOF {
return nil, fmt.Errorf("reading file %s : %w", header.Name, err)
}
if header.Mode < 0 && int64(uint32(header.Mode)) != header.Mode { //nolint:gosec // disable G115
return nil, errors.New("invalid mode value in tar header")
}
testFS[target] = &fstest.MapFile{
Data: data,
Mode: os.FileMode(header.Mode),
Mode: os.FileMode(header.Mode), //nolint:gosec // disable G115
ModTime: header.ModTime,
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/webhook/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ func ValidatePolicy(ctx context.Context, namespace string, ref name.Reference, c
switch {
case authority.Static != nil:
if authority.Static.Action == "fail" {
result.err = cosign.NewVerificationError("disallowed by static policy: " + authority.Static.Message)
result.err = cosign.NewVerificationError("disallowed by static policy: %s", authority.Static.Message)
results <- result
return
}
Expand Down

0 comments on commit bbc5216

Please sign in to comment.