Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose file #1560

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Feb 6, 2024

Make config path configurable

Add environment variable FULCIO_CONFIG to allow providing an alternate
configuration file rather than overwriting the default one. If a testing
environment overwrote the git-committed config/config.jsn, it would
pollute the repository checkout and be difficult to reuse on subsequent
test runs.

Needed by sigstore/cosign#3499

Add persistent volume for mysql

The ctfe_init container uses a persistent volume to store the tree head
ID among other things from previous runs. However, the mysql container
is not guaranteed to reuse the same data directory when it is destroyed
and recreated, so it may come up empty. When this happens, but the CT
log is configured for an existing tree, then signing objects will fail
with a Not Found error. This change adds a persistent volume to the
docker-compose file for mysql so that the database can live on and be
consistent with the CT log's configuration.

Summary

Release Note

Documentation

Add environment variable FULCIO_CONFIG to allow providing an alternate
configuration file rather than overwriting the default one. If a testing
environment overwrote the git-committed config/config.jsn, it would
pollute the repository checkout and be difficult to reuse on subsequent
test runs.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
The ctfe_init container uses a persistent volume to store the tree head
ID among other things from previous runs. However, the mysql container
is not guaranteed to reuse the same data directory when it is destroyed
and recreated, so it may come up empty. When this happens, but the CT
log is configured for an existing tree, then signing objects will fail
with a Not Found error. This change adds a persistent volume to the
docker-compose file for mysql so that the database can live on and be
consistent with the CT log's configuration.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@haydentherapper haydentherapper merged commit dfcb1eb into sigstore:main Feb 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants