Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move account manager under main binary #601

Merged
merged 4 commits into from
Nov 22, 2019
Merged

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Nov 13, 2019

Issue Addressed

NA

Proposed Changes

Removes the account_manager binary, place it's functionality under the lighthouse binary.

More info

Blocked on #542

@paulhauner paulhauner added work-in-progress PR is a work-in-progress and removed blocked labels Nov 15, 2019
@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 20, 2019
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulhauner paulhauner added this to the Public Testnet milestone Nov 21, 2019
@paulhauner paulhauner merged commit 03e18de into master Nov 22, 2019
@paulhauner paulhauner deleted the integrate-account-manager branch December 5, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants