Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth1 Integration #542

Merged
merged 255 commits into from
Nov 15, 2019
Merged

Eth1 Integration #542

merged 255 commits into from
Nov 15, 2019

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Sep 25, 2019 •
edited
Loading

Issue Addressed

Proposed Changes

  • Add functions to connect to an eth1 node to get relevant the Eth1Data using the web3 crate.
  • Add get_eth1_vote function to determine new state for Beacon chain state.eth1_data using the above data.
  • Addresses a bunch of clippy lints across the entire project.
    • There are also quite a few modifications from rustfmt
  • Allows the genesis Fork to be defined in ChainSpec.
  • Ensures the Fork for verifying Deposit is always a constant [0, 0, 0, 0].
    • Removes some unnecessary parameters from the deposit SignatureSet.
  • Unifies the beacon_node and validator_client into a single ligyhthouse binary.
    • Introduces the concept of an Environment and a Context, which provide access to tokio and logging.
  • Adds basic framework for testing a BeaconNode in-process
    • Allows for services to be started on port 0 (i.e., let the OS choose a free port) and read which port was actually used.

@pawanjay176
Refactor to cache Eth1Data
e290b6e
@pawanjay176
Fix merge conflicts and minor refactorings
2664f82
@pawanjay176
Rename Eth1Cache to Eth1DataCache
df63d1e
@pawanjay176
Refactor events subscription
01b6c02
@pawanjay176
Add deposits module to interface with BeaconChain deposits
8850419
@pawanjay176
Remove utils
0e0bf01
@pawanjay176
Rename to types.rs and add trait constraints to Eth1DataFetcher
e7c5a4f
@pawanjay176
Confirm to trait constraints. Make Web3DataFetcher cloneable
b2a1050
@pawanjay176
Make fetcher object member of deposit and eth1_data cache and other f…
557a929 
…ixes

* Fix update_cache function
* Move fetch_eth1_data to impl block
* Fix deposit tests
@pawanjay176
Create Eth1 object for interfacing with Beacon chain
3bdfe9a 
* Add `run` function for running update_cache and subscribe_deposit_logs tasks
* Add logging
@pawanjay176
Run cargo fmt and make tests pass
757eaf5
@pawanjay176
Convert sync functions to async
7417d97
@pawanjay176
Add timeouts to web3 functions
d471059
@pawanjay176
Return futures from cache functions
1164294
@pawanjay176
Add failed chaining of futures
e960f5b
@pawanjay176
Working cache updation
16738fa
@pawanjay176
Clean up tests and update_cache function
b297db9
@pawanjay176
Refactor get_eth1_data functions to work with future returning func…
02d8b78 
…tions
@pawanjay176
Refactor eth1 run function to work with modified update_cache api
db59dcd
@pawanjay176
Minor changes
9ca34b0
@pawanjay176
Add distance parameter to update_cache
37c92b0
@pawanjay176
Fix tests and other minor fixes
5367347
@pawanjay176
Working integration with cache and deposits
d74601b
@pawanjay176
Add merkle_tree construction, proof generation and verification code
f68c39a
@pawanjay176
Add function to construct and fetch Deposits for BeaconNode
845b496
@pawanjay176
Add error handling
89dbe18
@pawanjay176
Import ssz
96af512
@pawanjay176
Add error handling to eth1 cache and fix minor errors
8035c98
@pawanjay176
Run rustfmt
7fb83c2
@pawanjay176
Fix minor bug
6b9e675
@paulhauner paulhauner marked this pull request as ready for review November 12, 2019 03:57
@paulhauner
Copy link
Member Author

This is finally ready for review!

@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 12, 2019
@paulhauner paulhauner mentioned this pull request Nov 12, 2019
Closed
michaelsproul
michaelsproul requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah that's a lotta code. I think I've reviewed the most important parts thoroughly, and I've had a skim through the other parts.

I only found a few typos and nitpicks, no major changes. Happy to merge once they're addressed

Nice work!

beacon_node/beacon_chain/src/eth1_chain.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/eth1_chain.rs Show resolved Hide resolved
beacon_node/eth1/src/block_cache.rs Outdated Show resolved Hide resolved
beacon_node/eth1/src/deposit_cache.rs Outdated Show resolved Hide resolved
beacon_node/eth1/src/deposit_log.rs Outdated Show resolved Hide resolved
beacon_node/eth1/src/block_cache.rs Outdated Show resolved Hide resolved
beacon_node/eth1/src/deposit_cache.rs Outdated Show resolved Hide resolved
beacon_node/eth1/src/service.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/eth1_chain.rs Show resolved Hide resolved
beacon_node/beacon_chain/src/eth1_chain.rs Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 13, 2019
@paulhauner paulhauner mentioned this pull request Nov 13, 2019
Merged
michaelsproul
michaelsproul approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-to-merge and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 14, 2019
@paulhauner paulhauner mentioned this pull request Nov 15, 2019
Closed
@paulhauner paulhauner merged commit f229bbb into master Nov 15, 2019
@paulhauner paulhauner deleted the eth1 branch December 5, 2019 02:29
@winksaville winksaville mentioned this pull request Oct 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees

@paulhauner paulhauner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Eth1 RPC linking
3 participants
@paulhauner @michaelsproul @pawanjay176