Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add Ropsten configuration #3184

Closed
wants to merge 2 commits into from
Closed

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented May 17, 2022

Issue Addressed

NA

Proposed Changes

Adds the configuration for the upcoming merge of the Ropsten network, as per:

eth-clients/merge-testnets#9

Use the Ropsten network with: lighthouse --network ropsten

Additional Info

This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our unstable.

@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label May 17, 2022
@paulhauner
Copy link
Member Author

paulhauner commented May 17, 2022

Currently blocked on eth-clients/merge-testnets#9 (comment)

@paulhauner paulhauner added ready-for-review The code is ready for review and removed blocked work-in-progress PR is a work-in-progress labels May 18, 2022
@paulhauner paulhauner marked this pull request as ready for review May 18, 2022 06:50
@pawanjay176
Copy link
Member

Looks like the config was updated here eth-clients/merge-testnets@5b1b44a

@paulhauner paulhauner added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels May 18, 2022
@paulhauner
Copy link
Member Author

paulhauner commented May 20, 2022

Looks like the config was updated here eth-clients/merge-testnets@5b1b44a

That commit modifies shadow-fork-5, without touching ropsten. Thanks for point it out though!

This PR is up-to-date with eth-clients/merge-testnets@5cbccd4

@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels May 20, 2022
@michaelsproul
Copy link
Member

TTD is still subject to change, perhaps we should hold off merging until then?

ethereum/pm#527 (comment)

Or should we merge so we can roll out infra, and then ship an update as necessary?

@paulhauner
Copy link
Member Author

Or should we merge so we can roll out infra, and then ship an update as necessary?

I think this is my preference, but not a strong one.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Exciting to have a new network supported!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 20, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 20, 2022
## Issue Addressed

NA

## Proposed Changes

Adds the configuration for the upcoming merge of the Ropsten network, as per:

eth-clients/merge-testnets#9

Use the Ropsten network with: `lighthouse --network ropsten`

## Additional Info

This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our `unstable`.
@bors bors bot changed the title Add Ropsten configuration [Merged by Bors] - Add Ropsten configuration May 20, 2022
@bors bors bot closed this May 20, 2022
@paulhauner paulhauner deleted the ropsten branch November 24, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants