Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden the freezing procedure against failures #1323

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

adaszko
Copy link
Contributor

@adaszko adaszko commented Jul 1, 2020

Follow up to #1285 (comment)

Should be the last PR related to atomicity (#692).

@adaszko adaszko added the ready-for-review The code is ready for review label Jul 1, 2020
@adaszko adaszko force-pushed the master branch 3 times, most recently from 9f29e9d to e224591 Compare July 1, 2020 07:20
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual!

beacon_node/beacon_chain/tests/store_tests.rs Show resolved Hide resolved
beacon_node/store/src/hot_cold_store.rs Show resolved Hide resolved
beacon_node/store/src/hot_cold_store.rs Show resolved Hide resolved
beacon_node/store/src/hot_cold_store.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added ready-to-squerge and removed ready-for-review The code is ready for review labels Jul 2, 2020
@paulhauner paulhauner merged commit c7f47af into sigp:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants