EIP-2386 (draft): Eth2 wallet #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
blocked
work-in-progress
kirk-baird
requested changes
May 11, 2020
eth2/utils/eth2_wallet/src/wallet.rs
Outdated
| /// | ||
| /// - If `wallet_password` is unable to decrypt `self`. | ||
| /// - If `keystore_password.is_empty()`. | ||
| /// - If `self.nextaccount == u32::max_value() - 1`. |
There was a problem hiding this comment.
self.nextaccount == u32::max_value() ?
The checked_add() would fail when we add 1 to u32::max_value?
|
All comments addressed, thank you! |
paulhauner
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Implements the draft EIP-2386 for an encrypted BLS wallet with support for hierarchical key derivation.
Additional Info
Blocked on EIP-2335: Keystore #1071, EIP-2333: Key derivation #1104TODO
Zeroizeinbip39.