Support mlp classifier #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good in terms of structure and everything @santi1234567! Once CI is passing I'm happy to merge |
michaelsproul
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for utilizing an Multi-Layer Perceptron classifier (MLP). The
knn_classifiermodule is now calledclassifierand supports both algorithms with the optionalclassifier_typeparameter on the class. There is also the new--classifier-typeflag in theclassifier.pyscript.The MLP classifier has proven to achieve at least 3% more accuracy over the KNN one with most configurations tested by us. The only downside is that it takes more time to be trained.