Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #562 #573

Merged
merged 5 commits into from
May 4, 2024
Merged

fix #562 #573

merged 5 commits into from
May 4, 2024

Conversation

sigma67
Copy link
Owner

@sigma67 sigma67 commented Apr 5, 2024

closes #562

@sigma67 sigma67 changed the base branch from fix-get-album-544 to main April 5, 2024 18:54
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (2217f3d) to head (79a1186).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   95.92%   95.88%   -0.04%     
==========================================
  Files          36       36              
  Lines        2183     2187       +4     
==========================================
+ Hits         2094     2097       +3     
- Misses         89       90       +1     
Flag Coverage Δ
unittests 95.88% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hundredfire
Copy link

Hello! Looks like there are errors due to the test procedure? Is there anything we can help with?
Thank you for your work btw

@sigma67
Copy link
Owner Author

sigma67 commented May 2, 2024

Hi @hundredfire , thanks for the offer.

I'm mainly missing more test data for different playlists. I'm interested in playlists where the header (the metadata part) looks different, i.e. the order of the data changes. See #562 for some example screenshots

Currently we have tests for owned playlists and foreign playlists, so if you could provide some additional response data for those that would be great

@sigma67 sigma67 merged commit f53074e into main May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_playlist() format update
2 participants